e2e tests: consolidate azure nightly builds #1993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkulke
force-pushed
the
mkulke/consolidate-azure-nightly-builds
branch
2 times, most recently
from
52e4100 to
262654a
Compare
bpradipt
reviewed
Aug 9, 2024
mkulke
force-pushed
the
mkulke/consolidate-azure-nightly-builds
branch
2 times, most recently
from
a5f7bef to
4ab87d2
Compare
surajssd
approved these changes
Aug 9, 2024
bpradipt
reviewed
Aug 10, 2024
bpradipt
reviewed
Aug 10, 2024
| @@ -151,7 +151,8 @@ func DoTestCreatePeerPodContainerWithExternalIPAccess(t *testing.T, e env.Enviro | |||
|
|
|||
| func DoTestCreatePeerPodWithJob(t *testing.T, e env.Environment, assert CloudAssert) { | |||
| jobName := "job-pi" | |||
| job := NewJob(E2eNamespace, jobName) | |||
| image := "quay.io/prometheus/busybox:latest" | |||
| job := NewJob(E2eNamespace, image, 8, jobName) | |||
There was a problem hiding this comment.
Ordering of arguments is wrong here. Noticed it due to e2e failure
method signature: NewJob(namespace, name string, backoffLimit int32, image string, command ...string)
Several changes for the azure CI workflows and tests are introduced: - A single nightly-build workflow will build a podvm image and then use that image in a test. - A remote-attestation e2e test has been introduced that will only acquire an attestation token from kbs without requesting a secret. - Early exit in the job assertion logic. - Introduced configurable backofflimit for job tests. - Only run the simple pod and remote attestation tests for the time being. - Introduced jitter value in gh workflow matrix to avoid contention for cross-matrix resources (user assigned identity). Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
mkulke
force-pushed
the
mkulke/consolidate-azure-nightly-builds
branch
from
4ab87d2 to
fec4f77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several changes for the azure CI workflows and tests are introduced:
A single nightly-build workflow will build a podvm image and then use that image in a test.
A remote-attestation e2e test has been introduced that will only acquire an attestation token from kbs without requesting a secret.
Early exit in the job assertion logic.
Introduced configurable backofflimit for job tests.
Only run the simple pod and remote attestation tests for the time being.
Introduced jitter value in gh workflow matrix to avoid contention for cross-matrix resources (user assigned identity).