Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e-test: Remove naming conflicts #1974

Conversation

mkulke
Copy link
Collaborator

@mkulke mkulke commented Aug 2, 2024

Test should not create resources with the same name, because this will introduce race conditions if the tests run in parallel.

image

image

Test should not create resources with the same name, because this will
introduce race conditions if the tests run parallel.

Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
Copy link
Member

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mkulke mkulke added the test_e2e_libvirt Run Libvirt e2e tests label Aug 3, 2024
Copy link
Member

@liudalibj liudalibj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkulke mkulke merged commit 612ec49 into confidential-containers:main Aug 3, 2024
31 checks passed
@mkulke mkulke deleted the mkulke/fix-e2e-test-naming-conflict branch August 3, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test_e2e_libvirt Run Libvirt e2e tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants