e2e-test: assert job condition on job tests #1969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have elaborate condition checks on a job's pods, but we do not test the job status itself, which will produce wrong test results. A test for job that always fails (cmd: /bin/false) will pass. This keeps the current assertions in-place, but makes the test fail on a failed job status Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
mkulke
force-pushed
the
mkulke/add-jobstatus-assertion
branch
from
f163116 to
e0722c1
Compare
stevenhorsman
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have elaborate condition checks on a job's pods, but we do not test the job status itself, which will produce wrong test results. A test for job that always fails (cmd: /bin/false) will pass.
This keeps the current assertions in-place, but makes the test fail on a failed job status