-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cloud-config: streamline credentials provisioning #1850
cloud-config: streamline credentials provisioning #1850
Conversation
c9316d6
to
b323245
Compare
according to the discussion on the linked guest-component issue, we might end up having to add an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with moving the destination path for auth.json and removing it out of daemon.json, but I have a question on how we might be able to use it in image-rs
some changes need to be applied once #1933 has been merged |
b323245
to
22f4ddd
Compare
7432ced
to
a6d5d13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
instead of nesting it into a daemon.json property for the forwarder the auth file is being moved to its own entry, which will simplify the logic and allow cloud-init based podvms to use authenticated registries without running process-user-data alongside cloud-init. Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
a6d5d13
to
f08ea46
Compare
Instead of nesting it into a daemon.json property for the forwarder the auth file is being moved to its own entry, which will simplify the logic and allow cloud-init based podvms to use authenticated registries without running process-user-data alongside cloud-init.