libvirt: Fix config_libvirt to not exit #1826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
config_libvirt.sh has `set -o errexit`, so we can't use a grep for rhel and test if it fails as this will exit the script. Instead use the ID field from `/etc/os-release` or `/usr/lib/os-release` Signed-off-by: stevenhorsman <steven@uk.ibm.com>
|
Tried it on ubuntu, looks good to me. Thanks @stevenhorsman figure out the problem! |
And in fedora: Many scripts in kata will look for two locations like |
wainersm
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1822 broke the e2e libvirt tests jobs (https://github.com/confidential-containers/cloud-api-adaptor/actions/runs/8873277040/job/24359701508). We should have added the test_e2e_libvirt label, so sorry for missing that during the review.
config_libvirt.sh has
set -o errexit, so we can't use a grep for rhel and test if it fails as this will exit the script. Instead use the ID field from/etc/os-releaseor/usr/lib/os-release