-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: govulncheck is failed with new vulnerability GO-2024-2687 #1783
ci: govulncheck is failed with new vulnerability GO-2024-2687 #1783
Conversation
- fix https://pkg.go.dev/vuln/GO-2024-2687 Signed-off-by: Da Li Liu <liudali@cn.ibm.com>
- fix https://pkg.go.dev/vuln/GO-2024-2687 Signed-off-by: Da Li Liu <liudali@cn.ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks DaLi!
@@ -1,5 +1,5 @@ | |||
ARG BUILD_TYPE=dev | |||
ARG BUILDER_BASE=quay.io/confidential-containers/golang-fedora:1.21.8-38 | |||
ARG BUILDER_BASE=quay.io/confidential-containers/golang-fedora:1.21.9-38 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like this is not good:
ERROR: failed to solve: quay.io/confidential-containers/golang-fedora:1.21.9-38: failed to resolve source metadata for quay.io/confidential-containers/golang-fedora:1.21.9-38: quay.io/confidential-containers/golang-fedora:1.21.9-38: not found
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is my fault for suggesting DaLi update it. Maybe we have to do that as a separate bump as this image is only build after this PR is merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The quay.io/confidential-containers/golang-fedora:1.21.9-38
is not build yet, it should be triggered at https://github.com/confidential-containers/cloud-api-adaptor/blob/main/.github/workflows/build-golang-fedora.yaml after this PR be merged.
I think we can skip the e2e-test for this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, let's re-trigger the build if CI fails after merge because https://github.com/confidential-containers/cloud-api-adaptor/blob/main/.github/workflows/build-golang-fedora.yaml might be triggered later than caa.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I'll merge it and then check the tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After I waited for the golang-fedora base image build to happen I triggered the nightly libvirt tests and the podvm image builders passed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
7f4cc55
into
confidential-containers:main
fix the report issues from govulncheck CI.
for #1779
govulncheck is failed with error:
More details https://github.com/confidential-containers/cloud-api-adaptor/actions/runs/8593242256/job/23544455229?pr=1778