Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kustomize: upgrade kustomize to v5.3.0 #1731

Merged
merged 1 commit into from
Mar 12, 2024
Merged

kustomize: upgrade kustomize to v5.3.0 #1731

merged 1 commit into from
Mar 12, 2024

Conversation

liudalibj
Copy link
Member

@liudalibj liudalibj commented Mar 11, 2024 •
edited
Loading

  • upgrade kustomize to v5.3.0 which has s390x arch support

fixes #1732

snir911
snir911 approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@snir911 snir911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I wonder why peerpodsconfig doesn't have it, old operator-sdk? maybe it should be bumped ?

@liudalibj
Copy link
Member Author

liudalibj commented Mar 11, 2024 •
edited
Loading

Thanks! I wonder why peerpodsconfig doesn't have it, old operator-sdk? maybe it should be bumped ?

take a look on peerpodsconfig, it is using another way to install kustomize, and it is using kustomize@v4 latest version, that is v4.5.7
https://github.com/confidential-containers/cloud-api-adaptor/blob/main/peerpodconfig-ctrl/Makefile#L166
and it's has s390x support: https://github.com/kubernetes-sigs/kustomize/releases/tag/kustomize%2Fv4.5.7

huoqifeng
huoqifeng approved these changes Mar 11, 2024
View reviewed changes
Copy link

@huoqifeng huoqifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kustomize: upgrade kustomize to v5.3.0
9087863 
- upgrade kustomize to v5.3.0 which has s390x arch support
- sync get dep tools in peerpodconfig-ctrl with peerpod-ctrl

Signed-off-by: Da Li Liu <liudali@cn.ibm.com>
@liudalibj liudalibj force-pushed the fix-kustomize-s390x branch from dbced68 to 9087863 Compare March 11, 2024 09:13
@liudalibj
Copy link
Member Author

Thanks! I wonder why peerpodsconfig doesn't have it, old operator-sdk? maybe it should be bumped ?

update the get dep tools method in peerpodsconfig-ctrl, make it same as the one in peerpods-ctrl

stevenhorsman
stevenhorsman approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for unifying the approach that all three components take!

@liudalibj
Copy link
Member Author

As govulncheck issue is kwon issue, and we are working on it. To not block others tasks, I will merge this issue now.

@liudalibj liudalibj merged commit 72bbe68 into confidential-containers:main Mar 12, 2024
17 of 18 checks passed
@stevenhorsman stevenhorsman mentioned this pull request Mar 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snir911 snir911 snir911 approved these changes

@huoqifeng huoqifeng huoqifeng approved these changes

@stevenhorsman stevenhorsman stevenhorsman approved these changes

@bpradipt bpradipt Awaiting requested review from bpradipt

@genjuro214 genjuro214 Awaiting requested review from genjuro214

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

It's failed to deploy peerpod-ctrl from s390x machine.
4 participants
@liudalibj @snir911 @huoqifeng @stevenhorsman