Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: disable binary artifact caching in azure podvm builds #1713

Conversation

mkulke
Copy link
Collaborator

@mkulke mkulke commented Feb 23, 2024

The caching keys will not cover any modifications that we do to the build process, so we need to to rebuild the binaries on podvm builds.

@mkulke mkulke force-pushed the mkulke/dont-cache-binaries-in-az-build branch from 7aa1a4b to 5c03bcc Compare February 23, 2024 17:31
The caching keys will not cover any modifications that we do to the
build process, so we need to to rebuild the binaries on podvm builds.

Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
@mkulke mkulke force-pushed the mkulke/dont-cache-binaries-in-az-build branch from 5c03bcc to 05992ad Compare February 23, 2024 18:35
Copy link
Member

@surajssd surajssd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in principle.

Copy link
Contributor

@kartikjoshi21 kartikjoshi21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Thanks Magnus, This should remove blockers for e2e test.

@kartikjoshi21 kartikjoshi21 merged commit cfd5ae7 into confidential-containers:main Feb 26, 2024
18 checks passed
@mkulke mkulke deleted the mkulke/dont-cache-binaries-in-az-build branch February 26, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants