packer: add replication region to shared image gallery #1698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkulke
reviewed
Feb 19, 2024
| @@ -30,6 +30,7 @@ source "azure-arm" "ubuntu" { | |||
| image_name = "${var.az_gallery_image_name}" | |||
| image_version = "${var.az_gallery_image_version}" | |||
| storage_account_type = "Standard_LRS" | |||
| replication_regions = "eastus2" | |||
There was a problem hiding this comment.
note: replication_regions is an array, I think it makes sense to add eastus2 for TDX availability, we can also add westeurope, since it supports both tdx and snp vms
Suggested change
| replication_regions = "eastus2" | |
| replication_regions = ["eastus2", "westeurope"] |
There was a problem hiding this comment.
@mkulke added, thanks for the feedback!
Add eastus2 to replication regions in order to access the image from there. Signed-off-by: Chelsea Mafrica <chelsea.e.mafrica@intel.com>
cmaf
force-pushed
the
packer-replication-regions
branch
from
22c5619 to
a046bfa
Compare
bpradipt
approved these changes
Feb 20, 2024
|
yup should be replicated in the build. please note, if you plan to use it for tdx, the image might not be configured properly yet: #1703 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add eastus2 to replication regions in order to access the image from there.
Note: My understanding is that this will make the nightly build image available in eastus2 as well as eastus, is that the case? Per this comment from another thread #1696 (comment)