Provisioner: Add kbs provisioning steps in CI #1684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surajssd
reviewed
Feb 1, 2024
Comment on lines
+23
to
+33
| kbs-image-id: | ||
| type: string | ||
| description: prebuild kbs image | ||
| kbs-image-tag: | ||
| type: string | ||
| description: prebuild kbs image tag |
There was a problem hiding this comment.
Can't we read all this information from versions.yaml ?
There was a problem hiding this comment.
Yes we are reading it from version.yaml and we are also providing an option to give it in CI.
kartikjoshi21
force-pushed
the
kartikjoshi21/kbs-ci-update
branch
13 times, most recently
from
dd62057 to
8b87faf
Compare
kartikjoshi21
force-pushed
the
kartikjoshi21/kbs-ci-update
branch
4 times, most recently
from
39fec4f to
21f609f
Compare
kartikjoshi21
force-pushed
the
kartikjoshi21/kbs-ci-update
branch
from
21f609f to
d965550
Compare
kartikjoshi21
force-pushed
the
kartikjoshi21/kbs-ci-update
branch
from
d965550 to
bf542f0
Compare
mkulke
approved these changes
Mar 4, 2024
kartikjoshi21
force-pushed
the
kartikjoshi21/kbs-ci-update
branch
from
bf542f0 to
f7a4cd9
Compare
kartikjoshi21
force-pushed
the
kartikjoshi21/kbs-ci-update
branch
from
f7a4cd9 to
bd2fd38
Compare
kartikjoshi21
force-pushed
the
kartikjoshi21/kbs-ci-update
branch
from
bd2fd38 to
de18b08
Compare
kartikjoshi21
force-pushed
the
kartikjoshi21/kbs-ci-update
branch
from
de18b08 to
2a1582f
Compare
surajssd
requested changes
Apr 10, 2024
kartikjoshi21
force-pushed
the
kartikjoshi21/kbs-ci-update
branch
from
2a1582f to
68f50be
Compare
surajssd
reviewed
Apr 18, 2024
huoqifeng
reviewed
Apr 19, 2024
kartikjoshi21
force-pushed
the
kartikjoshi21/kbs-ci-update
branch
from
68f50be to
c246e59
Compare
Fixes: confidential-containers#1676 Signed-off-by: Kartik Joshi <kartikjoshi@microsoft.com>
kartikjoshi21
force-pushed
the
kartikjoshi21/kbs-ci-update
branch
from
c246e59 to
b672ac0
Compare
surajssd
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1676