-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e: update PodVM with Authenticated Registry cases #1681
e2e: update PodVM with Authenticated Registry cases #1681
Conversation
5afed39
to
a0ae962
Compare
d3fa11f
to
43fc78e
Compare
- add ImagePullSecret to default ServiceAccount - make these two test cases can be reused by other cloud providers - support given Authenticated Registry Fixes confidential-containers#1680 Signed-off-by: Da Li Liu <liudali@cn.ibm.com>
43fc78e
to
8c84227
Compare
Run e2e-test for ibmcloud base on this PR inside IBM firewall https://sys-zaas-k8s-jenkins.swg-devops.com/view/test/job/cloud-api-adaptor-e2e-tests-opensource-liudali-pr/9/console
|
The e2e-test for libvirt provider is passed too: https://github.com/confidential-containers/cloud-api-adaptor/actions/runs/7693729044/job/20967188593?pr=1681 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the fix @liudalibj!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #1680