Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

peerpod-ctrl: fix Make command docker-buildx #1649

Merged
merged 1 commit into from
Jan 10, 2024
Merged

peerpod-ctrl: fix Make command docker-buildx #1649

merged 1 commit into from
Jan 10, 2024

Conversation

genjuro214
Copy link
Contributor

When I tried to build peerpod-ctrl image locally with command make docker-buildx, it failed:

docker buildx build --push --platform=linux/arm64,linux/amd64,linux/s390x,linux/ppc64le --tag quay.io/cdlleili/peerpod-ctrl:latest -f Dockerfile.cross
ERROR: "docker buildx build" requires exactly 1 argument.

So I tried to fix it:

  • --platform=$TARGETPLATFORM has been set in Dockerfile, so we don't need to insert --platform=${BUILDPLATFORM} for cross-platform support
  • add 2 build args
  • add . as the latest argument

@genjuro214
peerpod-ctrl: fix Make command docker-buildx
60dfbf2 
Command docker-buildx cannot work

Signed-off-by: Lei Li <genjuro214@gmail.com>
Signed-off-by: Lei Li <cdlleili@cn.ibm.com>
@liudalibj
Copy link
Member

I run on ubuntu 20.04 amd64 vsi, meet follow issue:

make docker-buildx
...
?   	github.com/confidential-containers/cloud-api-adaptor/peerpod-ctrl/api/v1alpha1	[no test files]
ok  	github.com/confidential-containers/cloud-api-adaptor/peerpod-ctrl/controllers	0.822s	coverage: 0.0% of statements
docker buildx create --name project-v3-builder
project-v3-builder
docker buildx use project-v3-builder
docker buildx build --push --platform=linux/arm64,linux/amd64,linux/s390x,linux/ppc64le --tag quay.io/confidential-containers/peerpod-ctrl:latest --build-arg CGO_ENABLED=1 --build-arg GOFLAGS=-tags=aws,azure,ibmcloud,vsphere,libvirt -f Dockerfile .
...
 => [linux/amd64 stage-1 3/4] COPY --from=builder /workspace/manager .                                                                                                                                                                          0.1s
------
 > [linux/s390x stage-1 2/4] RUN if [ "1" = 1 ] ; then dnf install -y libvirt-libs openssh-clients && dnf clean all; fi:
#0 31.00 Fedora 38 - s390x                               2.8 MB/s |  76 MB     00:26
#0 213.4 Fedora 38 openh264 (From Cisco) - s390x         1.2 kB/s | 2.5 kB     00:02
#0 218.1 Fedora Modular 38 - s390x                       1.0 MB/s | 2.7 MB     00:02
#0 233.1 Fedora 38 - s390x - Updates                     3.3 MB/s |  30 MB     00:09
#0 317.0 Fedora Modular 38 - s390x - Updates             939 kB/s | 2.0 MB     00:02
#0 324.5 Last metadata expiration check: 0:00:02 ago on Thu Jan  4 09:30:56 2024.
#0 377.0 Dependencies resolved.
#0 377.2 ================================================================================
#0 377.2  Package               Arch      Version                      Repository   Size
#0 377.2 ================================================================================
#0 377.2 Installing:
#0 377.2  libvirt-libs          s390x     9.0.0-3.fc38                 updates     4.6 M
#0 377.2  openssh-clients       s390x     9.0p1-17.fc38                updates     728 k
#0 377.2 Installing dependencies:
#0 377.2  cyrus-sasl            s390x     2.1.28-9.fc38                fedora       78 k
#0 377.2  cyrus-sasl-gssapi     s390x     2.1.28-9.fc38                fedora       27 k
#0 377.2  libcbor               s390x     0.7.0-9.fc38                 fedora       56 k
#0 377.2  libedit               s390x     3.1-45.20221030cvs.fc38      fedora      116 k
#0 377.2  libfdisk              s390x     2.38.1-4.fc38                fedora      164 k
#0 377.2  libfido2              s390x     1.12.0-3.fc38                fedora       94 k
#0 377.2  libnl3                s390x     3.7.0-3.fc38                 fedora      349 k
#0 377.2  libssh2               s390x     1.10.0-7.fc38                fedora      123 k
#0 377.2  libutempter           s390x     1.2.1-8.fc38                 fedora       26 k
#0 377.2  libwsman1             s390x     2.7.1-10.fc38                fedora      140 k
#0 377.2  numactl-libs          s390x     2.0.16-2.fc38                fedora       32 k
#0 377.2  openssh               s390x     9.0p1-17.fc38                updates     444 k
#0 377.2  util-linux            s390x     2.38.1-4.fc38                fedora      2.3 M
#0 377.2  yajl                  s390x     2.1.0-21.fc38                updates      39 k
#0 377.2
#0 377.2 Transaction Summary
#0 377.2 ================================================================================
#0 377.2 Install  16 Packages
#0 377.2
#0 377.2 Total download size: 9.3 M
#0 377.2 Installed size: 43 M
#0 377.2 Downloading Packages:
#0 379.7 (1/16): cyrus-sasl-gssapi-2.1.28-9.fc38.s390x.r  41 kB/s |  27 kB     00:00
#0 379.7 (2/16): libcbor-0.7.0-9.fc38.s390x.rpm           80 kB/s |  56 kB     00:00
#0 379.8 (3/16): cyrus-sasl-2.1.28-9.fc38.s390x.rpm       99 kB/s |  78 kB     00:00
#0 379.8 (4/16): libedit-3.1-45.20221030cvs.fc38.s390x.r 796 kB/s | 116 kB     00:00
#0 379.9 (5/16): libfdisk-2.38.1-4.fc38.s390x.rpm        922 kB/s | 164 kB     00:00
#0 379.9 (6/16): libfido2-1.12.0-3.fc38.s390x.rpm        843 kB/s |  94 kB     00:00
#0 380.0 (7/16): libssh2-1.10.0-7.fc38.s390x.rpm         1.0 MB/s | 123 kB     00:00
#0 380.0 (8/16): libutempter-1.2.1-8.fc38.s390x.rpm      217 kB/s |  26 kB     00:00
#0 380.1 (9/16): libnl3-3.7.0-3.fc38.s390x.rpm           1.5 MB/s | 349 kB     00:00
#0 380.1 (10/16): libwsman1-2.7.1-10.fc38.s390x.rpm      1.1 MB/s | 140 kB     00:00
#0 380.2 (11/16): numactl-libs-2.0.16-2.fc38.s390x.rpm   265 kB/s |  32 kB     00:00
#0 380.4 (12/16): util-linux-2.38.1-4.fc38.s390x.rpm     6.4 MB/s | 2.3 MB     00:00
#0 380.5 (13/16): openssh-9.0p1-17.fc38.s390x.rpm        2.0 MB/s | 444 kB     00:00
#0 380.5 (14/16): yajl-2.1.0-21.fc38.s390x.rpm           997 kB/s |  39 kB     00:00
#0 380.6 (15/16): openssh-clients-9.0p1-17.fc38.s390x.rp 4.8 MB/s | 728 kB     00:00
#0 380.8 (16/16): libvirt-libs-9.0.0-3.fc38.s390x.rpm    6.6 MB/s | 4.6 MB     00:00
#0 380.9 --------------------------------------------------------------------------------
#0 380.9 Total                                           2.6 MB/s | 9.3 MB     00:03
#0 381.2 error: rpmdbNextIterator: skipping h#     147
#0 381.2 Header SHA256 digest: BAD (Expected 00860bfd04cdc945c7c7cac713e35d455fc5dbef296994d98c0c3a853b7bbfd5 != 000000000000000000000000000000000)
#0 381.2 Header SHA1 digest: BAD (Expected fedab432fd3970ee437f3a53a707311e00e75bee != feeeeeeeeeeeeeeeeeeee)
#0 381.5 error: rpmdbNextIterator: skipping h#     147
#0 381.5 Header SHA256 digest: BAD (Expected 00860bfd04cdc945c7c7cac713e35d455fc5dbef296994d98c0c3a853b7bbfd5 != 000000000000000000000000000000000)
#0 381.5 Header SHA1 digest: BAD (Expected fedab432fd3970ee437f3a53a707311e00e75bee != feeeeeeeeeeeeeeeeeeee)
#0 381.9 error: rpmdbNextIterator: skipping h#     147
#0 381.9 Header SHA256 digest: BAD (Expected 00860bfd04cdc945c7c7cac713e35d455fc5dbef296994d98c0c3a853b7bbfd5 != 000000000000000000000000000000000)
#0 381.9 Header SHA1 digest: BAD (Expected fedab432fd3970ee437f3a53a707311e00e75bee != feeeeeeeeeeeeeeeeeeee)
#0 382.2 error: rpmdbNextIterator: skipping h#     147
#0 382.2 Header SHA256 digest: BAD (Expected 00860bfd04cdc945c7c7cac713e35d455fc5dbef296994d98c0c3a853b7bbfd5 != 000000000000000000000000000000000)
#0 382.2 Header SHA1 digest: BAD (Expected fedab432fd3970ee437f3a53a707311e00e75bee != feeeeeeeeeeeeeeeeeeee)
#0 382.5 error: rpmdbNextIterator: skipping h#     147
#0 382.5 Header SHA256 digest: BAD (Expected 00860bfd04cdc945c7c7cac713e35d455fc5dbef296994d98c0c3a853b7bbfd5 != 000000000000000000000000000000000)
#0 382.5 Header SHA1 digest: BAD (Expected fedab432fd3970ee437f3a53a707311e00e75bee != feeeeeeeeeeeeeeeeeeee)
#0 382.8 error: rpmdbNextIterator: skipping h#     147
#0 382.8 Header SHA256 digest: BAD (Expected 00860bfd04cdc945c7c7cac713e35d455fc5dbef296994d98c0c3a853b7bbfd5 != 000000000000000000000000000000000)
#0 382.8 Header SHA1 digest: BAD (Expected fedab432fd3970ee437f3a53a707311e00e75bee != feeeeeeeeeeeeeeeeeeee)
#0 383.1 error: rpmdbNextIterator: skipping h#     147
#0 383.1 Header SHA256 digest: BAD (Expected 00860bfd04cdc945c7c7cac713e35d455fc5dbef296994d98c0c3a853b7bbfd5 != 000000000000000000000000000000000)
#0 383.1 Header SHA1 digest: BAD (Expected fedab432fd3970ee437f3a53a707311e00e75bee != feeeeeeeeeeeeeeeeeeee)
#0 383.5 error: rpmdbNextIterator: skipping h#     147
#0 383.5 Header SHA256 digest: BAD (Expected 00860bfd04cdc945c7c7cac713e35d455fc5dbef296994d98c0c3a853b7bbfd5 != 000000000000000000000000000000000)
#0 383.5 Header SHA1 digest: BAD (Expected fedab432fd3970ee437f3a53a707311e00e75bee != feeeeeeeeeeeeeeeeeeee)
#0 383.9 error: rpmdbNextIterator: skipping h#     147
#0 383.9 Header SHA256 digest: BAD (Expected 00860bfd04cdc945c7c7cac713e35d455fc5dbef296994d98c0c3a853b7bbfd5 != 000000000000000000000000000000000)
#0 383.9 Header SHA1 digest: BAD (Expected fedab432fd3970ee437f3a53a707311e00e75bee != feeeeeeeeeeeeeeeeeeee)
#0 384.2 error: rpmdbNextIterator: skipping h#     147
#0 384.2 Header SHA256 digest: BAD (Expected 00860bfd04cdc945c7c7cac713e35d455fc5dbef296994d98c0c3a853b7bbfd5 != 000000000000000000000000000000000)
#0 384.2 Header SHA1 digest: BAD (Expected fedab432fd3970ee437f3a53a707311e00e75bee != feeeeeeeeeeeeeeeeeeee)
#0 384.5 error: rpmdbNextIterator: skipping h#     147
#0 384.5 Header SHA256 digest: BAD (Expected 00860bfd04cdc945c7c7cac713e35d455fc5dbef296994d98c0c3a853b7bbfd5 != 000000000000000000000000000000000)
#0 384.5 Header SHA1 digest: BAD (Expected fedab432fd3970ee437f3a53a707311e00e75bee != feeeeeeeeeeeeeeeeeeee)
#0 384.8 error: rpmdbNextIterator: skipping h#     147
#0 384.8 Header SHA256 digest: BAD (Expected 00860bfd04cdc945c7c7cac713e35d455fc5dbef296994d98c0c3a853b7bbfd5 != 000000000000000000000000000000000)
#0 384.8 Header SHA1 digest: BAD (Expected fedab432fd3970ee437f3a53a707311e00e75bee != feeeeeeeeeeeeeeeeeeee)
#0 385.4 error: rpmdbNextIterator: skipping h#     147
#0 385.4 Header SHA256 digest: BAD (Expected 00860bfd04cdc945c7c7cac713e35d455fc5dbef296994d98c0c3a853b7bbfd5 != 000000000000000000000000000000000)
#0 385.4 Header SHA1 digest: BAD (Expected fedab432fd3970ee437f3a53a707311e00e75bee != feeeeeeeeeeeeeeeeeeee)
#0 386.3 error: rpmdbNextIterator: skipping h#     147
#0 386.3 Header SHA256 digest: BAD (Expected 00860bfd04cdc945c7c7cac713e35d455fc5dbef296994d98c0c3a853b7bbfd5 != 000000000000000000000000000000000)
#0 386.3 Header SHA1 digest: BAD (Expected fedab432fd3970ee437f3a53a707311e00e75bee != feeeeeeeeeeeeeeeeeeee)
#0 386.6 error: rpmdbNextIterator: skipping h#     147
#0 386.6 Header SHA256 digest: BAD (Expected 00860bfd04cdc945c7c7cac713e35d455fc5dbef296994d98c0c3a853b7bbfd5 != 000000000000000000000000000000000)
#0 386.6 Header SHA1 digest: BAD (Expected fedab432fd3970ee437f3a53a707311e00e75bee != feeeeeeeeeeeeeeeeeeee)
#0 387.2 error: rpmdbNextIterator: skipping h#     147
#0 387.2 Header SHA256 digest: BAD (Expected 00860bfd04cdc945c7c7cac713e35d455fc5dbef296994d98c0c3a853b7bbfd5 != 000000000000000000000000000000000)
#0 387.2 Header SHA1 digest: BAD (Expected fedab432fd3970ee437f3a53a707311e00e75bee != feeeeeeeeeeeeeeeeeeee)
#0 387.2 Problem opening package cyrus-sasl-2.1.28-9.fc38.s390x.rpm
#0 387.2 Problem opening package cyrus-sasl-gssapi-2.1.28-9.fc38.s390x.rpm
#0 387.2 Problem opening package libcbor-0.7.0-9.fc38.s390x.rpm
#0 387.2 Problem opening package libedit-3.1-45.20221030cvs.fc38.s390x.rpm
#0 387.2 Problem opening package libfdisk-2.38.1-4.fc38.s390x.rpm
#0 387.2 Problem opening package libfido2-1.12.0-3.fc38.s390x.rpm
#0 387.2 Problem opening package libnl3-3.7.0-3.fc38.s390x.rpm
#0 387.2 Problem opening package libssh2-1.10.0-7.fc38.s390x.rpm
#0 387.2 Problem opening package libutempter-1.2.1-8.fc38.s390x.rpm
#0 387.2 Problem opening package libwsman1-2.7.1-10.fc38.s390x.rpm
#0 387.2 Problem opening package numactl-libs-2.0.16-2.fc38.s390x.rpm
#0 387.3 Problem opening package util-linux-2.38.1-4.fc38.s390x.rpm
#0 387.3 Problem opening package libvirt-libs-9.0.0-3.fc38.s390x.rpm
#0 387.3 Problem opening package openssh-9.0p1-17.fc38.s390x.rpm
#0 387.3 Problem opening package openssh-clients-9.0p1-17.fc38.s390x.rpm
#0 387.3 Problem opening package yajl-2.1.0-21.fc38.s390x.rpm
#0 387.3 The downloaded packages were saved in cache until the next successful transaction.
#0 387.3 You can remove cached packages by executing 'dnf clean packages'.
#0 387.5 Error: GPG check FAILED
------
Dockerfile:34
--------------------
  32 |     ARG CGO_ENABLED=1
  33 |
  34 | >>> RUN if [ "$CGO_ENABLED" = 1 ] ; then dnf install -y libvirt-libs openssh-clients && dnf clean all; fi
  35 |     WORKDIR /
  36 |     COPY --from=builder /workspace/manager .
--------------------
error: failed to solve: process "/bin/sh -c if [ \"$CGO_ENABLED\" = 1 ] ; then dnf install -y libvirt-libs openssh-clients && dnf clean all; fi" did not complete successfully: exit code: 1
make: [Makefile:158: docker-buildx] Error 1 (ignored)
docker buildx rm project-v3-builder

@snir911
Copy link
Contributor

snir911 commented Jan 4, 2024

The latter error seems like unrelated issue no? you get it only with this PR?
FWIW, this is file was auto generated, i wonder if it's version related

liudalibj
liudalibj approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@liudalibj liudalibj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a new amd64 ubutu22.04 8x32 vsi, try to make docker-buildx, it works now.
thanks @genjuro214

@liudalibj
Copy link
Member

The latter error seems like unrelated issue no? you get it only with this PR? FWIW, this is file was auto generated, i wonder if it's version related

Yeah, it seems that the env or network issue, not related this PR.
I got a good build after I use a new VSI.

huoqifeng
huoqifeng approved these changes Jan 10, 2024
View reviewed changes
Copy link

@huoqifeng huoqifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huoqifeng huoqifeng merged commit 86d18fe into confidential-containers:main Jan 10, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huoqifeng huoqifeng huoqifeng approved these changes

@liudalibj liudalibj liudalibj approved these changes

@snir911 snir911 Awaiting requested review from snir911

@stevenhorsman stevenhorsman Awaiting requested review from stevenhorsman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@genjuro214 @liudalibj @snir911 @huoqifeng