Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update doc to add ibmcloud specific properties #1647

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

wyuany
Copy link
Contributor

@wyuany wyuany commented Dec 31, 2023

Add more details to document to run e2e test on ibmcloud

Fixes: #1646

Copy link
Member

@liudalibj liudalibj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one blanksapce need be removed,
Others LGTM.

@liudalibj liudalibj requested a review from huoqifeng January 3, 2024 02:26
test/e2e/README.md Outdated Show resolved Hide resolved
test/e2e/README.md Outdated Show resolved Hide resolved
@wyuany wyuany force-pushed the doc-ibmcloud-update branch from 79fc285 to 45406bd Compare January 3, 2024 03:17
Add more details to document to run e2e test on ibmcloud

Fixes: confidential-containers#1646

Signed-off-by: Yuan Yuan Wang <wyuany@cn.ibm.com>
@wyuany wyuany force-pushed the doc-ibmcloud-update branch from 45406bd to 1edbb33 Compare January 3, 2024 03:19
Copy link

@huoqifeng huoqifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huoqifeng huoqifeng merged commit 2dcfaa9 into confidential-containers:main Jan 5, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc: Include properties details to run e2e test case of ibmcloud.
4 participants