Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

podvm: fix podvm packer image build #1617

Merged
merged 1 commit into from
Dec 6, 2023
Merged

podvm: fix podvm packer image build #1617

merged 1 commit into from
Dec 6, 2023

Conversation

liudalibj
Copy link
Member

@liudalibj liudalibj commented Dec 6, 2023 •
edited
Loading

  • pined the pakcer version to 1.9.4-1 which still in MPL license, and with this old version podvm image build with packer work as expected.

fixes #1616

huoqifeng
huoqifeng reviewed Dec 6, 2023
View reviewed changes
podvm/Makefile Outdated Show resolved Hide resolved
@liudalibj liudalibj changed the title podvm: fix podvm packaer image build podvm: fix podvm packer image build Dec 6, 2023
podvm: fix podvm packer image build
eae4f28 
- use the packer version 1.9.4-1, the version which still under the MPL license

fixes confidential-containers#1616

Signed-off-by: Da Li Liu <liudali@cn.ibm.com>
stevenhorsman
stevenhorsman approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, thanks. I'll try running the libvirt CI to see if they pass too!

@stevenhorsman stevenhorsman added the test_e2e_libvirt Run Libvirt e2e tests label Dec 6, 2023
@stevenhorsman
Copy link
Member

@wainersm - we are getting failures in the ci libvirt e2e tests: https://github.com/confidential-containers/cloud-api-adaptor/actions/runs/7116127949/job/19375394250?pr=1617 when the image download is done:

Run qcow2=$(echo ghcr.io/confidential-containers/podvm-generic-ubuntu-amd64:ci-pr1617 | sed -e "s#.*/\(.*\):.*#\1.qcow2#")
Error:  please install docker or podman

Have you seen this before?

@wainersm wainersm mentioned this pull request Dec 6, 2023
Merged
wainersm
wainersm approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@wainersm wainersm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @liudalibj !

@wainersm
Copy link
Member

wainersm commented Dec 6, 2023

The podvm images are built so this really fix the problem. I will merge it then check yet another fix for the libvirt e2e

@wainersm wainersm merged commit 63ba59b into confidential-containers:main Dec 6, 2023
28 of 29 checks passed
@liudalibj liudalibj deleted the podvm-packer-qemu branch December 7, 2023 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huoqifeng huoqifeng huoqifeng left review comments

@tumberino tumberino tumberino approved these changes

@stevenhorsman stevenhorsman stevenhorsman approved these changes

@wainersm wainersm wainersm approved these changes

@bpradipt bpradipt Awaiting requested review from bpradipt

Assignees
No one assigned
Labels
test_e2e_libvirt Run Libvirt e2e tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

podvm image with packer is failed
6 participants
@liudalibj @stevenhorsman @wainersm @bpradipt @huoqifeng @tumberino