terraform: add new variables for existing VPC and subnet #1592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
genjuro214
requested review from
stevenhorsman,
tumberino,
liudalibj and
huoqifeng
Enable the creation of VSIs in existing VPC and subnet Signed-off-by: Lei Li <genjuro214@gmail.com> Signed-off-by: Lei Li <cdlleili@cn.ibm.com>
|
@tumberino would you please have a look at that? thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current IBM Cloud terraform to create self-managed cluster will always create new VPC and subnet for VSIs.
As a result, it's easy to see vpc quota exceeded errors because by default only 10 VPCs could be created in a region under an account.
In this PR, we introduced 2 new variables to specify existing VPC and subnet names. If they are set, will create VSIs in existing VPC; otherwise, will create new VPC and subnet as usual