Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: daily libvirt e2e-test with podvm-generic-ubuntu-amd64 podvm image #1589

Merged
merged 1 commit into from
Nov 21, 2023
Merged

e2e: daily libvirt e2e-test with podvm-generic-ubuntu-amd64 podvm image #1589

merged 1 commit into from
Nov 21, 2023

Conversation

liudalibj
Copy link
Member

  • show e2e-test result for libvirt cloud_provider base on self-managed amd64 cluster base libvirt
  • only push images when it not in registry

fixes: #1588

e2e: daily libvirt e2e-test (amd64)
141ca17 
- show e2e-test result for libvirt cloud_provider base on self-managed amd64 cluster base libvirt
- only push images when it not in registry

fixes: #1588

Signed-off-by: Da Li Liu <liudali@cn.ibm.com>
@liudalibj
Copy link
Member Author

tested at here: https://github.com/confidential-containers/cloud-api-adaptor/actions/runs/6926459077/job/18838647518

@liudalibj liudalibj changed the title e2e: daily libvirt e2e-test (amd64) e2e: daily libvirt e2e-test with podvm-generic-ubuntu-amd64 podvm image Nov 20, 2023
huoqifeng
huoqifeng approved these changes Nov 20, 2023
View reviewed changes
Copy link

@huoqifeng huoqifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@huoqifeng
Copy link

I saw License Compliance error in PR check but I think it's a known issue. I also noticed errors in the the test result but not a e2e pipeline issue either, so, I think it's good, thanks @liudalibj

@stevenhorsman
Copy link
Member

I saw License Compliance error in PR check but I think it's a known issue.

Yes, this comes up as this branch was pushed to the upstream, rather than a fork, so it's best to follow that approach in future

stevenhorsman
stevenhorsman approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@liudalibj liudalibj merged commit c936d17 into main Nov 21, 2023
20 of 24 checks passed
@liudalibj liudalibj deleted the e2e-libvirt-amd64 branch November 21, 2023 02:09
@liudalibj liudalibj restored the e2e-libvirt-amd64 branch November 21, 2023 02:09
@liudalibj liudalibj deleted the e2e-libvirt-amd64 branch November 21, 2023 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenhorsman stevenhorsman stevenhorsman approved these changes

@huoqifeng huoqifeng huoqifeng approved these changes

@genjuro214 genjuro214 Awaiting requested review from genjuro214

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show e2e-test result for libvirt Cloud Provider in opensource e2e-pipelines
3 participants
@liudalibj @huoqifeng @stevenhorsman