Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/e2e: KBS property incorrectly required #1724

Closed
stevenhorsman opened this issue Mar 5, 2024 · 1 comment · Fixed by #1722
Closed

tests/e2e: KBS property incorrectly required #1724

stevenhorsman opened this issue Mar 5, 2024 · 1 comment · Fixed by #1722
Assignees
@stevenhorsman

Comments

@stevenhorsman
Copy link
Member

When running a libvirt test (to check it is still okay after the CI hasn't been working for ~2 weeks 😢). I was hitting an issue about KBS image propertie not being provided:

# make test-e2e
go test -v -tags=libvirt -timeout 50m -count=1 ./test/e2e
time="2024-03-05T14:42:01Z" level=info msg="Do setup"
F0305 14:42:01.840056   24072 env.go:369] Setup failure: kbs image not provided
FAIL	github.com/confidential-containers/cloud-api-adaptor/test/e2e	0.041s
FAIL
make: *** [Makefile:95: test-e2e] Error 1

However I didn't set DEPLOY_KBS=yes, so I don't think is should be needed.

I guess this shows the importance of those CI checks!
@stevenhorsman stevenhorsman self-assigned this Mar 5, 2024
stevenhorsman added a commit to stevenhorsman/cloud-api-adaptor that referenced this issue Mar 5, 2024
@stevenhorsman
test/e2e: Only check KBS image property if required
64dfa9f 
Skip the kbs image property if we aren't deploying the KBS in the tests

Fixes: confidential-containers#1724
Signed-off-by: stevenhorsman <steven@uk.ibm.com>
@stevenhorsman stevenhorsman mentioned this issue Mar 5, 2024
Closed
@stevenhorsman
Copy link
Member Author

FYI I've added #1726 to port Magnus' mkosi fix into packer, to hopefully fix the podvm issue and had my kcli PR merged, so hopefully we are getting closer to having working CI again!

@stevenhorsman stevenhorsman linked a pull request Mar 6, 2024 that will close this issue
test-e2e: Make KBS opt-in for e2e tests #1722
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevenhorsman stevenhorsman

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@stevenhorsman