Skip to content
This repository has been archived by the owner on Nov 21, 2023. It is now read-only.

Readd az-snp-vtpm verifier #103

Merged

Conversation

mkulke
Copy link
Contributor

@mkulke mkulke commented Jun 1, 2023

Readded the az-snp-vtpm verifier to the default verifiers, so it will get built in kbs, also adjusted the paths that have been used in the tests to match the refactoring.

fixes confidential-containers/trustee#193

Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
Copy link
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fitzthum
Copy link
Member

fitzthum commented Jun 1, 2023

@mkulke @Xynnn007 Should we create a 0.6.1 AS release and try to sneak this into v0.6.0 or wait until v0.7.0?

@mkulke
Copy link
Contributor Author

mkulke commented Jun 2, 2023

@mkulke @Xynnn007 Should we create a 0.6.1 AS release and try to sneak this into v0.6.0 or wait until v0.7.0?

If it's tolerable effort it would be nice to have it in v0.6.

@Xynnn007
Copy link
Member

Xynnn007 commented Jun 2, 2023

If it's tolerable effort it would be nice to have it in v0.6.

I'm Ok with this as KBS has not been published yet.

@Xynnn007 Xynnn007 merged commit 436e13e into confidential-containers:main Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

az-snp-vtpm verifier has been removed from all-verifier feature
3 participants