Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use amqp's ability to use both URI & conn-options #89

Merged
merged 3 commits into from
Sep 12, 2022

Conversation

b1az
Copy link
Contributor

@b1az b1az commented Nov 17, 2021

Bumped the amqp version as this ability was
introduced in amqp 1.3.0:
pma/amqp#144

@b1az
Copy link
Contributor Author

b1az commented Sep 12, 2022

Hi @blatyo. Last time you mentioned on Slack that you weren't sure whether to (already, when the PR was opened) bump the required amqp version. As it's now been more than 3 years since its 1.3.0 release, do you think this PR may be merged? (It would help me move a client's project dependency off of my fork and back to the conduitframework organization.)

CI-related: 3722eae did help and a new, further error was returned by CircleCI. Regardless, feel free to drop this and/or 2b96e7d commit.

@blatyo blatyo merged commit a1b9cad into conduitframework:master Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants