Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zsh also uses sh as shell extension #223

Merged
merged 2 commits into from
Jun 21, 2023
Merged

zsh also uses sh as shell extension #223

merged 2 commits into from
Jun 21, 2023

Conversation

wolfv
Copy link
Contributor

@wolfv wolfv commented Jun 20, 2023

This should fix activation for zsh shells (didn't find and execute any activation scripts).

@baszalmstra baszalmstra self-requested a review June 20, 2023 09:37
@baszalmstra
Copy link
Collaborator

What happens with powershell though? That will only find ps1 files right?

@wolfv
Copy link
Contributor Author

wolfv commented Jun 20, 2023

afaik powershell isn't able to execute cmd.exe (.bat) files and the syntax is wildly different.

@wolfv wolfv merged commit 11309d1 into conda:main Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baszalmstra baszalmstra baszalmstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wolfv @baszalmstra