feat: topological sort of PackageRecords #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfv
approved these changes
Jun 16, 2023
wolfv
reviewed
Jun 16, 2023
| } | ||
|
|
||
| /// Retrieves the names of the packages that form the roots of the graph | ||
| fn get_graph_roots<T: AsRef<PackageRecord>>(records: &[T]) -> Vec<String> { |
There was a problem hiding this comment.
I think this function might fall apart if we have multiple package records with the same name in the vector, right?
Since version 0 might be at the root, but if version 1 adds some dependencies it might not be at the root anymore.
We might want to clarify that this works only for lists of unique package names.
There was a problem hiding this comment.
Good one, I added this to the docs.
wolfv
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds topological sorting of
PackageRecords fromrattler-server. This implementation differs slightly in that it allows anyVecof something that resembles aPackageRecordto be sorted. This includesRepoDataRecordandPrefixRecord.