Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change blake2 hash to use blake2b instead of blake2s #192

Merged
merged 8 commits into from
May 22, 2023

Conversation

travishathaway
Copy link
Contributor

@travishathaway travishathaway commented May 18, 2023

While working on the JLAP implementation, I discovered that the blake2 hash that rattle_repodata_gateway generates isn't compatible with the ones found in the repodata.jlap files currently being generated by the server (rattler uses blake2s and JLAP uses blake2b).

This pull request switches rattler_repodata_gateway to use blake2b.

Comments and suggestions for improvements welcome.

@baszalmstra
Copy link
Collaborator

I thinks its fine to switch the hash type. I also think rattler_digest contains a few things you implemented here or was that not sufficient.

@travishathaway
Copy link
Contributor Author

@baszalmstra,

I'm guessing I overlooked a few things from rattler_digest. If it's okay to switch hash types, that makes things easier though. I can re-work this pull request to do that instead 👍.

@travishathaway travishathaway changed the title Add blake2b hash to .state.json file in repodata cache Change blake2 hash to use blake2b instead of blake2s May 18, 2023
@wolfv wolfv merged commit 001f326 into conda:main May 22, 2023
@wolfv
Copy link
Contributor

wolfv commented May 22, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants