Only delete Menu when empty
#218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
jaimergp
reviewed
Jun 5, 2024
Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
jaimergp
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
Menudirectories are currently removed even if multiple apps share the same folder. In other words, if two apps install into the same Start Menu directory, uninstalling one of these apps will remove the entire directory. This is a regression frommenuinst v1.The same behavior happens on Linux, which doesn't appear to be the intention since
_remove_this_menu()is only called if there are no additional items in theMenu. The unlinking happens regardless though.This PR ensures that the
Menudirectory is only removed if the directory associated withMenuare indeed empty after allMenuItemshave been removed.I also noticed that when removing a Windows Terminal Profile via
conda, the message "Could not find terminal profile for {name}.", presumably because theremoveoperation is executed twice. I think that message isn't helpful in either case, so I removed it here (not worth a separate PR).Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?