Fix menuinst._legacy.cwp
#168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
jaimergp
approved these changes
Dec 9, 2023
jaimergp
reviewed
Dec 10, 2023
| @@ -7,41 +7,48 @@ | |||
| import sys | |||
| from os.path import join, pathsep | |||
|
|
|||
| from menuinst._legacy.knownfolders import FOLDERID, get_folder_path | |||
There was a problem hiding this comment.
For the record, this was the bad import.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unfortunately one of the imports done in
menuinst._legacy.cwpis invalid and breaks menuinst v1 style shortcuts on Windows.Resolve #167
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?Add / update outdated documentation?