Enable elevation on non-Windows platforms #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
jaimergp
commented
Jun 29, 2023
| @@ -352,6 +350,7 @@ def wrapper_elevate( | |||
| f"{func.__name__}(" | |||
| f"*{args!r}," | |||
| f"base_prefix={base_prefix!r}," | |||
| f"_mode='system'," | |||
There was a problem hiding this comment.
@mrclary - this was the bug 😬
There was a problem hiding this comment.
... when .noadmin is absent and user_is_admin() is False. So when a non-admin user runs menuinst from the commandline? When constructor runs for all users, user_is_admin() should return True, correct?
There was a problem hiding this comment.
Yea, I meant in addition to the early return fix you pointed out in the comment.
As you mention, this fixes CLI driven installs, like conda or menuinst. Your report also led me to adding conda/constructor@3f0b97b.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #137
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?