Skip to content

Commit

Permalink
do not quote icons
Browse files Browse the repository at this point in the history
  • Loading branch information
jaimergp committed Jul 2, 2024
1 parent b9dfa8e commit 006c579
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions menuinst/platforms/win_utils/registry.py
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,8 @@ def register_file_extension(
if icon:
# NOTE: This doesn't change the icon next in the Open With menu
# This defaults to whatever the command executable is shipping
regvalue(f"{key}/{identifier}/DefaultIcon/@", f'{icon},0')
regvalue(f"{key}/{identifier}/shell/open/Icon", f'{icon},0')
regvalue(f"{key}/{identifier}/DefaultIcon/@", icon)
regvalue(f"{key}/{identifier}/shell/open/Icon", icon)

if friendly_type_name:
# NOTE: Windows <10 requires the string in a PE file, but that's too
Expand Down Expand Up @@ -138,8 +138,8 @@ def register_url_protocol(
regvalue(f"{key}/FriendlyAppName/@", app_name)
regvalue(f"{key}/shell/open/FriendlyAppName", app_name)
if icon:
regvalue(f"{key}/DefaultIcon/@", f'"{icon}"')
regvalue(f"{key}/shell/open/Icon", f'"{icon}"')
regvalue(f"{key}/DefaultIcon/@", icon)
regvalue(f"{key}/shell/open/Icon", icon)
if app_user_model_id:
regvalue(f"{key}/AppUserModelId", app_user_model_id)
if identifier:
Expand Down

0 comments on commit 006c579

Please sign in to comment.