Restrict Windows installation directory permission based on installation mode #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
marcoesters
changed the title
This is exactly the situation that could re-introduce the CVE since we cannot prevent the installer from being executed with admin privileges. I am closing this PR - we need to find a better solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Windows installer restricts permissions for users if the installation was done with administrator privileges. It was reported in #872 that this can create a situation where a
JustMeinstallation restricts write access to the installation directory whenUAC_IsAdminmistakenly thinks the user is an administrator.Instead of checking for administrative privileges, check whether the installation is an
AllUsersinstallation. Privileges should be elevated at this point anyway and reflects the intent of the user. AJustMeinstallation should not be able to write into a sensitive directory in the first place since it never requires admin privileges (even though you could always run the installer as administrator to circumvent that).Closes #872.
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?