only insert custom_conclusion if the file ends in .nsi
#701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
|
@larsoner - this should fix the problems you saw in the MNE updates! |
marcoesters
reviewed
Jul 20, 2023
Co-authored-by: Marco Esters <mesters@anaconda.com>
marcoesters
reviewed
Jul 20, 2023
| # Custom conclusion file(s) | ||
| @CUSTOM_CONCLUSION_FILE@ | ||
|
|
||
| #else |
There was a problem hiding this comment.
This is pretty fundamental change. To restore old behavior, our custom conclusion files will have to add !insertmacro MUI_PAGE_FINISH, correct?
There was a problem hiding this comment.
Correct, that was always the intention IIRC, but this sneaked in. Otherwise you can't replace the last page (like the example tries to do), and you get two "Finish" pages which feels weird.
There was a problem hiding this comment.
Two finish pages may be desirable from a marketing perspective, but I do agree that we shouldn't force a default page. I'm all for more flexibility
marcoesters
approved these changes
Jul 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #700
A non-nsi
conclusion_file(e.g. a RTF file) would leak into the NSIS template, creating syntax errors.Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?