use channel_remap for envs.txt too

[EisW]

Description

Fix #654

Created installer with private channels does not find the package(s) from private channel during install.
This occured on Windows and Linux, but should be alike for OSX

Checklist - did you ...

• Add a file to the news directory (using the template) for the next release's release notes?
• Add / update necessary tests?
• Add / update outdated documentation?

[conda-bot]

We require contributors to sign our Contributor License Agreement and we don't have one on file for @EisW.

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature.

[EisW]

The added example, (with test instructions as comment in it) generates "myinstaller-0.0.1.sh"

Without the provided fix the installer fails with assertion:

[user@machine ~]$ sh myinstaller-0.0.1-Linux-x86_64.sh -p pytest123 -b
PREFIX=/home/user/pytest123
Unpacking payload ...

Installing base environment...


Downloading and Extracting Packages


# >>>>>>>>>>>>>>>>>>>>>> ERROR REPORT <<<<<<<<<<<<<<<<<<<<<<

    Traceback (most recent call last):
      File "conda/exceptions.py", line 1118, in __call__
      File "conda/cli/main.py", line 69, in main_subshell
      File "conda/cli/conda_argparse.py", line 91, in do_call
      File "conda/notices/core.py", line 109, in wrapper
      File "conda/cli/main_install.py", line 20, in execute
      File "conda/cli/install.py", line 191, in install
      File "conda/misc.py", line 113, in explicit
    AssertionError: Missing package cache records for: mychannel/linux-64::bitvector==3.5.0=pyhd8ed1ab_0[md5=6ef8a839230e9f9b5ca18b50e5f7a116]

`$ /home/user/pytest123/conda.exe install --offline --file /home/user/pytest123/pkgs/env.txt -yp /home/user/pytest123`

  environment variables:
                 CIO_TEST=<not set>
           CONDA_CHANNELS=conda-forge
CONDA_EXTRA_SAFETY_CHECKS=no
          CONDA_PKGS_DIRS=/home/user/pytest123/pkgs
               CONDA_ROOT=/home/user/pytest123/install_tmp/_MEIKtdIsq
      CONDA_SAFETY_CHECKS=disabled
           CURL_CA_BUNDLE=<not set>
          LD_LIBRARY_PATH=/home/user/pytest123/install_tmp/_MEIKtdIsq
               LD_PRELOAD=<not set>
      OLD_LD_LIBRARY_PATH=
                     PATH=/home/user/.local/bin:/home/user/bin:/usr/local/bin:/usr/bin:/us
                          r/local/sbin:/usr/sbin
       REQUESTS_CA_BUNDLE=<not set>
            SSL_CERT_FILE=<not set>

     active environment : None
       user config file : /home/user/.condarc
 populated config files :
          conda version : 22.11.1
    conda-build version : not installed
         python version : 3.9.15.final.0
       virtual packages : __archspec=1=x86_64
                          __glibc=2.28=0
                          __linux=4.18.0=0
                          __unix=0=0
       base environment : /home/user/pytest123/install_tmp/_MEIKtdIsq  (read only)
      conda av data dir : /home/user/pytest123/install_tmp/_MEIKtdIsq/etc/conda
  conda av metadata url : None
           channel URLs : https://conda.anaconda.org/conda-forge/linux-64  (offline)
                          https://conda.anaconda.org/conda-forge/noarch  (offline)
          package cache : /home/user/pytest123/pkgs
       envs directories : /home/user/.conda/envs
                          /home/user/pytest123/install_tmp/_MEIKtdIsq/envs
               platform : linux-64
             user-agent : conda/22.11.1 requests/2.28.1 CPython/3.9.15 Linux/4.18.0-425.13.1.el8_7.x86_64 rocky/8.7 glibc/2.28
                UID:GID : 1000:1000
             netrc file : None
           offline mode : True


An unexpected error has occurred. Conda has prepared the above report.

Upload successful.

With the fix it rans perfectly and installation is usable (tested under Windows and Linux)

[jaimergp]

Can we provide this as a little script under scripts/ so we test this in CI? 🙏

[EisW]

> Can we provide this as a little script under scripts/ so we test this in CI?

I will try it, makes sense      Gesendet: Montag, 13. März 2023 um 12:45 Uhr Von: "jaimergp" ***@***.***> An: "conda/constructor" ***@***.***> Cc: "Tino Winkler" ***@***.***>, "Mention" ***@***.***> Betreff: Re: [conda/constructor] use channel_remap for envs.txt too (PR #656)   @jaimergp commented on this pull request. In examples/use_channel_remap/construct.yaml:

+# prepare private channel first:

+# (1) create folder for channel: mkdir -p /tmp/mychannel/linux-64 +# (2) copy a private package into channel: +# (2.1) simulate with package from conda-forge: wget https://anaconda.org/conda-forge/bitvector/3.5.0/download/noarch/bitvector-3.5.0-pyhd8ed1ab_0.conda +# (2.2) cp bitvector-3.5.0-pyhd8ed1ab_0.conda /tmp/mychannel/linux-64/ +# (2.3) Create index (required for usage): conda index /tmp/mychannel +# (3) Now create installer: constructor examples/use_channel_remap/ Can we provide this as a little script under scripts/ so we test this in CI? 🙏 — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>

[EisW]

CLA Check failed again: must I sign again? Or is this just a barrier to prevent automatic merge?

Btw: with a little hack the channel remap is now tested within CI.

[jaimergp]

CLA Check failed again: must I sign again?

This has to be manually approved by someone at Anaconda. @jezdez @dbast - can anyone check please? Thanks!

[jezdez]

This was merged earlier today in conda/infrastructure#729

[jezdez]

@conda-bot check

[EisW]

Sorry, do not understand the failed test: may some temporary condition on CI?
I assume no difference in codepath between the OS versions

[jaimergp]

Let's re-run it. Maybe there's a repodata issue in defaults for macos, but that'd be weird. We could use conda-forge for the example and see if that provides a passing test.

[EisW]

What confuses me: it must be related to remap, because the very same construct.yaml, only without remap from examples/miniconda did work only seconds before.   But why only for Python=3.9, this is strange. Unfortunately I have no OSX available.   Suggestion:   (1) rerun the test without modifications (just in case) (1a) if (1) fails again, I would like to see the complete contents of local var repodatas preconda.py:write_index_cache() at the given line       (by adding a "print(repodatas)" and rerun (means chckin the print and rerun I think) (2) your suggestion: modify source channel to conda-forge instead main Message ID: ***@***.***>

[jaimergp]

Well it worked :)