Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to conda 23.11.0 (with menuinst v2) #36

Merged
merged 57 commits into from
Dec 19, 2023
Merged

Conversation

jaimergp
Copy link
Collaborator

@jaimergp jaimergp commented Aug 21, 2023

Description

Bump to latest conda and conda-libmamba-solver. Notably, this includes changes in how menuinst is called.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Aug 21, 2023
@jaimergp
Copy link
Collaborator Author

Failures should be fixed when conda/conda#11882 is merged and released. In the meantime we can patch conda-standalone to include that, or just wait.

@jaimergp jaimergp changed the title Bundle menuinst v2 Bump to conda 23.11.0 (with menuinst v2) Dec 12, 2023
.github/workflows/tests.yml Outdated Show resolved Hide resolved
@jaimergp jaimergp marked this pull request as ready for review December 15, 2023 12:20
@jaimergp jaimergp requested a review from a team as a code owner December 15, 2023 12:20
jezdez
jezdez previously approved these changes Dec 15, 2023
Comment on lines -215 to -218
if sys.platform != "win32":
raise NotImplementedError(
"Menu creation and removal is only supported on Windows"
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

tests/test_main.py Outdated Show resolved Hide resolved
.github/workflows/tests.yml Outdated Show resolved Hide resolved
jaimergp and others added 2 commits December 17, 2023 21:36
Co-authored-by: Jannis Leidel <jannis@leidel.info>
@jaimergp jaimergp requested a review from jezdez December 18, 2023 07:11
jezdez and others added 2 commits December 18, 2023 16:54
Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
@jezdez jezdez merged commit d06b2c7 into conda:main Dec 19, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants