Improve umask handling and ability to mock for tests #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dholth
force-pushed
the
umask-not-default-argument
branch
from
8ea2a5f to
6d1cf2a
Compare
dholth
force-pushed
the
umask-not-default-argument
branch
from
6d1cf2a to
d37dbc4
Compare
dholth
commented
Oct 2, 2024
| @@ -61,7 +61,7 @@ def chmod(self, tarinfo, targetpath): | |||
| umask. | |||
| """ | |||
| try: | |||
| os.chmod(targetpath, tarinfo.mode & (0o777 - self.umask)) | |||
| os.chmod(targetpath, tarinfo.mode & (-1 & (~self.umask))) | |||
There was a problem hiding this comment.
improved mask calculation
dholth
commented
Oct 2, 2024
dholth
changed the title
jezdez
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Split umask change from #96 to separate filter, umask test issues.