Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix .conda extension replacement; improve typing #257

Merged
merged 7 commits into from
Aug 27, 2024
Merged

Conversation

dholth
Copy link
Contributor

@dholth dholth commented Jul 26, 2024

Description

Fix #251 and another extension changer

Improve type annotations on an internal method

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@dholth dholth self-assigned this Jul 26, 2024
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jul 26, 2024
@dholth dholth requested a review from kenodegard August 14, 2024 16:01
@dholth dholth changed the title Improve typing Fix .conda extension replacement; improve typing Aug 14, 2024
@jezdez jezdez merged commit 65a13e9 into main Aug 27, 2024
15 checks passed
@jezdez jezdez deleted the improve-typing branch August 27, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

cph create is broken when --out-fn includes any sort of path
3 participants