Fix in SquashFSArchive._add #248 #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can not create hard-link on Linux when source file is owned by root but conda-pack runs as non-root user.
|
We require contributors to sign our Contributor License Agreement and we don't have one on file for @Kirill888. In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#870), and ping the bot to refresh the PR. |
|
@conda-bot check |
conda-bot
added
the
cla-signed
|
Can you please add a news item? Then we can merge this. |
xhochy
approved these changes
Jan 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can not create hard-link on Linux when source file is owned by root but conda-pack runs as non-root user.
Description
Fixing issue #248, when
condais installed asrootandconda-packruns as non-root, hard-linking activate script from conda installation directory to temp folder fails. So we check that source and destination are by the same user and on the same filesystem before deciding to use more efficient link instead of costlier copy.Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?