Refactor lock command and fix an edge case #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am sometimes confused why it just prints the help message.
✅ Deploy Preview for conda-lock ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
maresb
force-pushed
the
refactor-lock-command
branch
from
d48f415
to
4393305
Compare
maresb
changed the title
Leave it as an empty list, at least in the beginning.
maresb
force-pushed
the
refactor-lock-command
branch
from
4393305
to
69a9820
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before, when no lockfile was found by
conda-lock renderit would print the help and exit. Now it also prints a helpful error message that no lockfile was found.Before, when no source files were found by
conda-lock lockit would print the help and exit. Now it also prints a helpful error message that no source files were provided.For the case when no source files are specified, the logic to reconstruct the environment files from a lockfile has been split into a helper function.
Several type hints for the Click function
lockwere incorrect, so these have been corrected. Some corresponding minor adjustments were also made to appease mypy.Omitted CLI parameters are handled more explicitly for the lockfile path and source paths. In particular, we better distinguish the cases "no value provided" and "default value provided".
Related to the previous point, we now correctly handle the case of using CLI parameters to override the source files defined in a lockfile when the override coincides with the default value and consolidate the code for handling empty source files.