Use a quicker example for the channel-inversion test #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for conda-lock ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Great to see you around @mariusvniekerk!!! I'm just charging full speed ahead because my default assumption is that you're busy. Please feel free to chime in on anything/everything. I'm especially interested in your feedback on this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This test case has an average duration of 141 seconds, compared with the next-highest durations in the 70-90s range for
test_run_lock*. Now this test runs in 25 seconds.AFAICT we just need to check that the lockfile references a package with an out-of-order channel when that channel is specified. The newer example should accomplish this with a much lower overhead.