Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove credentials from response URLs #600

Merged
merged 1 commit into from
Feb 10, 2024

Conversation

wholtz
Copy link

@wholtz wholtz commented Feb 10, 2024

Closes #594. Please let me know if there is a better approach.

@wholtz wholtz requested a review from a team as a code owner February 10, 2024 07:33
Copy link

netlify bot commented Feb 10, 2024

Deploy Preview for conda-lock ready!

Name Link
🔨 Latest commit 6384043
🔍 Latest deploy log https://app.netlify.com/sites/conda-lock/deploys/65c7acc3deede200084e5ddf
😎 Deploy Preview https://deploy-preview-600--conda-lock.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@maresb maresb force-pushed the response_url_credentials branch from b920ea2 to 6384043 Compare February 10, 2024 17:05
Copy link
Contributor

@maresb maresb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @wholtz for the simple and elegant solution. It's really nice!!!

I reset your merge commit because there is no chance of interference and I'd like to keep this PR clean.

@maresb maresb merged commit b2ae6d8 into conda:main Feb 10, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Password supplied via environment variable in environment.yaml is expanded in conda-lock.yml
2 participants