Increase minimum ensureconda version for py3.12 compatibility #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to ensureconda v1.4.4 distutils is used, which was removed in python 3.12. This prevents conda-lock running under python newer than 3.11, so the minimum version of ensureconda is increased. Fixes #542
✅ Deploy Preview for conda-lock ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
maresb
approved these changes
Feb 5, 2024
|
Thanks @jfrost-mo! Feel free to ping me if it's green and not merged. |
|
Just pushed a fix for #596 |
|
I was too slow with #598 then. You probably want to add packaging as an explicit dependency to the pyproject.toml now its directly used. I'll go ahead and do that. |
|
No, it's already there, thanks though! |
|
Line 57 in 2c2999b |
|
Oops, I'll revert my change then. |
maresb
approved these changes
Feb 5, 2024
2 tasks
|
@maresb CI is all passing now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to ensureconda v1.4.4 distutils is used, which was removed in python 3.12. This prevents conda-lock running under python newer than 3.11, so the minimum version of ensureconda is increased.
Fixes #542
Fixes #596
The fix involves switching from distutils.version to packaging.version from the packaging package, which is maintained by the pypa.
The conda-lock.yml files will need regenerating after this PR.