Replace unnecessary Popen with subprocess.run #582
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#581 raised the issue of I/O deadlock with our use of
subprocess.Popen
and proposed solving this with threads. In this PR I take a step back and suggest thatsubprocess.Popen
is unnecessary and can be replaced withsubprocess.run
. This simplifies the subprocess call and obviates the need for threads.