Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace unnecessary Popen with subprocess.run #582

Closed
wants to merge 1 commit into from

Conversation

maresb
Copy link
Contributor

@maresb maresb commented Jan 16, 2024

#581 raised the issue of I/O deadlock with our use of subprocess.Popen and proposed solving this with threads. In this PR I take a step back and suggest that subprocess.Popen is unnecessary and can be replaced with subprocess.run. This simplifies the subprocess call and obviates the need for threads.

Copy link

netlify bot commented Jan 16, 2024

Deploy Preview for conda-lock ready!

Name Link
🔨 Latest commit 8ef256d
🔍 Latest deploy log https://app.netlify.com/sites/conda-lock/deploys/65a658fe346cce0008b081fa
😎 Deploy Preview https://deploy-preview-582--conda-lock.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@maresb maresb force-pushed the subprocess-popen-to-run branch from b7b3d05 to 8ef256d Compare January 16, 2024 10:22
@maresb
Copy link
Contributor Author

maresb commented Jan 18, 2024

Rejected in favor of #581

@maresb maresb closed this Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant