Don't filter in toposort #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise it's logically confusing, and it led to conda#556
✅ Deploy Preview for conda-lock ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Merged
|
Any progress on this? |
|
Sorry, this stalled out as I couldn't figure out if my assertion was correct. I suppose we could remove it and proceed blindly, or better replace it with a warning and ask the user to file a report if it's false. @mariusvniekerk, any insight here? It would be nice to either get test coverage on L122 or remove it as unnecessary. |
While __or__ is fancy, using "merge" is more self-explanatory, and it makes introspection easier.
maresb
force-pushed
the
dont-filter-in-toposort
branch
from
19009f0 to
41ae11f
Compare
|
I'm dropping my assertion and will follow it up later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before this PR, toposort would drop items (the virtual packages). I wouldn't expect a sort operation to do this. This is a major bug hazard, see #556 and also potentially #557. I've spit this out filtering into a separate step.
Other commits implement some minor cleanups along the way.