Implement auth stripping for private PyPi packages #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for conda-lock ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jacksmith15
commented
Jul 17, 2023
Comment on lines
+1328
to
+1330
| lockfile_content = read_file(os.path.join(tempdir, file)) | ||
| lockfile_content = _strip_auth_from_lockfile(lockfile_content) | ||
| write_file(lockfile_content, os.path.join(filename_template_dir, file)) |
There was a problem hiding this comment.
A small readability improvement, lockfile refers to a file-path earlier in this function's scope.
jacksmith15
force-pushed
the
feat/461/private-pypi-strip-auth
branch
from
7f5867f to
84c8702
Compare
jacksmith15
force-pushed
the
feat/461/private-pypi-strip-auth
branch
from
84c8702 to
cf5dcb4
Compare
maresb
reviewed
Jul 17, 2023
Co-authored-by: Ben Mares <services-git-throwaway1@tensorial.com>
maresb
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issue: #461
Related PRs: #323
#323 aimed to implement
--strip-authsupport for private PyPi packages, however it only targeted--kind explicitlockfiles.This PR adds support for
--kind locklockfiles (the default, unified kind).To achieve this, I pass the
--strip-authflag through to the resolver, and strip HTTP Basic auth from the URLs. This avoids the need for first writing a temporary lockfile containing the credentials, and then fixing them after the fact. It also avoids edge cases where users may have requested multiple types of lockfiles.Currently only HTTP Basic auth is supported for private PyPi repositories, so this should catch all cases.