-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update+apply pre-commit, prepare for pre-commit.ci, add badge #327
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally I prefer the transparency of GHA, but for the case of pre-commit, I agree that it probably makes more sense to use pre-commit.ci.
Also, we should probably merge this sooner rather than later to get the isort fix.
Ok. Going to enable pre-commit.ci for the repo (and changing the required status checks) ... and close / re-open the PR should then show that it works. |
tests/conftest.py: error: Source file found twice under different module names: "conftest" and "tests.conftest" tests/conftest.py: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#mapping-file-paths-to-modules for more info tests/conftest.py: note: Common resolutions include: a) adding `__init__.py` somewhere, b) using `--explicit-package-bases` or adjusting MYPYPATH Found 1 error in 1 file (errors prevented further checking)
Had to fix the error:
Added a see also python/mypy#4008 This is now green on pre-commit.ci and locally with |
Thanks a lot for this! All green now. I noticed one more local mypy error on my side, corrected in dbast#2 |
Now that CI has finished, I'll merge it in this branch... |
ping @mariusvniekerk |
Description
Update+apply pre-commit hooks (isort requires an update to work again).
This also prepares for the usage of pre-commit.ci:
I am (as member of the @conda/infrastucture team) happy to enable pre-commit.ci for this repo, if the @conda/conda-lock agrees to the idea of using pre-commit.ci. That said, I am also fine with descoping the PR to updates only and sticking to GH Actions.