Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filelock as a dependency #313

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

mariusvniekerk
Copy link
Collaborator

This seems to be needed for some classes of pip based resolution

This seems to be needed for some classes of pip based resolution
@netlify
Copy link

netlify bot commented Jan 12, 2023

Deploy Preview for conda-lock ready!

Name Link
🔨 Latest commit 3ff3a0a
🔍 Latest deploy log https://app.netlify.com/sites/conda-lock/deploys/63c0368d9b01de000ab1e1fe
😎 Deploy Preview https://deploy-preview-313--conda-lock.netlify.app/src_pyproject
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@maresb
Copy link
Contributor

maresb commented Jan 13, 2023

As of four months ago, filelock >=3.8.0 should already be implicit in cachecontrol[filecache]. But explicit is better than implicit.

I'm concerned about removing the pip-support option and breaking pipelines, but a quick experiment shows that pip only emits a warning, so I think we're good.

@maresb
Copy link
Contributor

maresb commented Jan 13, 2023

Closes #299

@mariusvniekerk mariusvniekerk merged commit 5bc4e6c into conda:main Jan 13, 2023
@mariusvniekerk mariusvniekerk deleted the deps-add-filelock branch January 13, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants