Add "platform_system" to the environment when solving in Pypi #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without it, the following YAML:
channels:
- conda-forge
dependencies:
- pip
- pip:
- twisted
Will result in bringing in twisted-iocpsupport when solving on Linux despite
the fact that that package is for Windows only.
This was due to the platform_system marker missing.
This PR also adds linux_{arch} for Linux platforms which is similar to what
packaging does (see https://github.com/pypa/packaging/blob/main/packaging/tags.py#L434).
✅ Deploy Preview for conda-lock ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without it, the following YAML:
Will result in bringing in twisted-iocpsupport when solving on Linux despite the fact that that package is for Windows only.
This was due to the platform_system marker missing.
This PR also adds linux_{arch} for Linux platforms which is similar to what packaging does (see https://github.com/pypa/packaging/blob/main/packaging/tags.py#L434).