Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version test which fails in local development #250

Merged
merged 2 commits into from
Oct 8, 2022

Conversation

maresb
Copy link
Contributor

@maresb maresb commented Oct 3, 2022

Sometimes __version__ looks like 0.11.3.dev370+g315f170 and the part after .dev is often out-of-sync when doing local development. So we check only for the part before, in this case just 0.11.3.

@netlify
Copy link

netlify bot commented Oct 3, 2022

Deploy Preview for conda-lock ready!

Name Link
🔨 Latest commit 7b5e06f
🔍 Latest deploy log https://app.netlify.com/sites/conda-lock/deploys/63406ef02c57a10009e2f073
😎 Deploy Preview https://deploy-preview-250--conda-lock.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@maresb
Copy link
Contributor Author

maresb commented Oct 7, 2022

Oops, this was ready to go, but I forgot to mark this as ready-for-review.

@maresb maresb marked this pull request as ready for review October 7, 2022 18:25
@mariusvniekerk mariusvniekerk merged commit d29fc5b into conda:main Oct 8, 2022
@maresb maresb deleted the fix-version-test branch October 8, 2022 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants