Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add --version flag #249

Merged
merged 5 commits into from
Oct 2, 2022
Merged

add --version flag #249

merged 5 commits into from
Oct 2, 2022

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Sep 30, 2022 •
edited
Loading

References

Changes

  • adds click.version_option
  • sort, normalize, and deduplicate requirements.txt
  • test

@netlify
Copy link

netlify bot commented Sep 30, 2022 •
edited
Loading

✅ Deploy Preview for conda-lock ready!

Name Link
🔨 Latest commit dacdc8e
🔍 Latest deploy log https://app.netlify.com/sites/conda-lock/deploys/63371519f2f4c50008bcf683
😎 Deploy Preview https://deploy-preview-249--conda-lock.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bollwyvl
Copy link
Contributor Author

Doesn't seem like the windows fail is related.

bollwyvl
bollwyvl commented Sep 30, 2022
View reviewed changes
requirements.txt
ruamel.yaml
poetry
toml
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should probably start using tomli...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, confused with pytoml, which is definitely deprecated.

https://github.com/uiri/toml hasn't had a substantive PR merged in some time, and many open issues, but is probably still fine.

I guess the biggest thing in favor of tomli is it's just the parsing side, and is the basis for the upcoming tomllib in stdlib: https://peps.python.org/pep-0680/#rationale

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to make a or to shift to tomli (or I guess preferentially the stdlib one for py 3.11/12) that would be awesome.

@mariusvniekerk mariusvniekerk merged commit 3d26575 into conda:main Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariusvniekerk mariusvniekerk mariusvniekerk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

conda-lock --version doesn't work
2 participants
@bollwyvl @mariusvniekerk