Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are a few really minor refactoring things I did in preparation for vendoring Poetry in #240, which should be very straightforward to review.
pip
was listed twice as a dependency inCONTRIBUTING.md
.dep
was being used as bothDependency
andLockedDependency
types, so to make type checkers happier, I renamed theLockedDependency
instances ofdep
tolocked_dep
.HashModel
object, it is possible (from the typing perspective if not in practice) thatlink.hash_name
andlink.hash
areNone
. ThusHashModel(**{link.hash_name: link.hash})
would expand toHashModel(None=None)
, which would result inTypeError: keywords must be strings
. I rewrote this bit of code to be a bit lengthier, but more explicit and robust.