Switch from setuptools to Hatch #239
Conversation
✅ Deploy Preview for conda-lock ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
I think we need to solve #235 in order to get the tests to pass. But @mariusvniekerk, does this otherwise look good? There's obviously more to improve, but it seems to me like that can be done in separate PRs. |
| ] | ||
| readme = "README.md" | ||
| license = "MIT" | ||
| requires-python = ">=3.6" |
There was a problem hiding this comment.
fyi Hatchling is 3.7+ so builder job can't use that
There was a problem hiding this comment.
but hatch can still build for older pythons right? its just metadata
There was a problem hiding this comment.
Ok, so we might need to adjust the workflows so that we build with 3.7+ before testing with 3.6.
But @mariusvniekerk, is there any benefit to supporting 3.6? Conda-forge stopped 3.6 builds some time ago. Plus, one could always condax install conda-lock to have it run in an isolated environment with modern Python.
| @@ -71,7 +70,6 @@ jobs: | |||
| echo "${PATH}" | |||
| which pip | |||
| which python | |||
| python -m pip install -r requirements.txt | |||
There was a problem hiding this comment.
pretty sure we need this for the poetry test dep?
There was a problem hiding this comment.
I removed it since requirements-dev.txt contains the line
-r requirements.txt
But perhaps we should instead remove that line and explicitly install those separately.
Or even better, we may want to leverage Hatch environments. But I'd prefer to do that in a separate PR. I'm trying to limit the current scope to switching from setuptools.
|
Rebased on #241 |
|
Looks good in general, probably needs a rebase to get rid of the already added fixes for virtual packages |
|
Awesome, thanks!!! I have already rebased on those exact commits, so apart from the merge commit it should merge completely cleanly. I'll rebase anyway on the merge commit, since it's no effort... |
Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
|
All green now. (Seems there is a sporadic crash on the Windows job.) |
|
Saw a sporadic crash on the osx on too on dev. Mostly nothing to be too worried about |
No description provided.