Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved tests using the "test-update" directory #226

Merged
merged 4 commits into from
Jul 28, 2022
Merged

Conversation

mariusvniekerk
Copy link
Collaborator

This should reduce some of the spurious errors observed in some test runs.

  • Additionally reworked how test directories were made. They should now all be fully isolated from each other
    by making use of the tmp_path fixture.
  • Added a futility used during the few install tests to ensure that we never run >1 install at a time as that
    inevitably leads to download locking issues in conda/mamba

…test runs.

Additionally reworked how test directories were made.  They should now all be fully isolated from each other
by making use of the tmp_path fixture.
Added a futility used during the few install tests to ensure that we never run >1 install at a time as that
inevitably leads to download locking issues in conda/mamba
@netlify
Copy link

netlify bot commented Jul 28, 2022

Deploy Preview for conda-lock ready!

Name Link
🔨 Latest commit c2e1a11
🔍 Latest deploy log https://app.netlify.com/sites/conda-lock/deploys/62e2b9643752c300086ba82c
😎 Deploy Preview https://deploy-preview-226--conda-lock.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@ericdill ericdill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first commit seems primarily adding types, formatting and removing lockfile usage. remaining commits seem straightforward enough. if there's anything hairy in that first commit that I should take a closer look at lmk, otherwise :shipit: imo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants