Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ${ENV_VAR} syntax #224

Merged
merged 8 commits into from
Jul 31, 2022
Merged

Conversation

jonashaag
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Jul 20, 2022

Deploy Preview for conda-lock ready!

Name Link
🔨 Latest commit 0092410
🔍 Latest deploy log https://app.netlify.com/sites/conda-lock/deploys/62e413e891be0800086e0e88
😎 Deploy Preview https://deploy-preview-224--conda-lock.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jonashaag
Copy link
Contributor Author

@mariusvniekerk something seems off with CI that's unrelated to my changes.

@mariusvniekerk
Copy link
Collaborator

@jonashaag Something doesn't seem quite right for the pattern matching. For token matching it might be simpler to just include { and } to the matched character class than the lookahead thing you're trying here.

@jonashaag
Copy link
Contributor Author

I was missing a ? after the } but I agree that we don't have to be so strict.

@jonashaag jonashaag marked this pull request as ready for review July 29, 2022 17:08
@mariusvniekerk mariusvniekerk merged commit 7d9bd6d into conda:main Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants