Allow channel::package in package specifications #207
Conversation
✅ Deploy Preview for conda-lock ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| if package_channel: | ||
| channel_str = package_channel.canonical_name | ||
| else: | ||
| channel_str = None |
There was a problem hiding this comment.
i think this else block is unnecessary given that ms.get('channel') will return None. But I guess if ms['channel'] is anything falsy ("", false, etc.) then this forces channel_str to be None. so maybe this is fine? idk. probably better to be defensive here and leave the code as is, instead of deleting the else block
There was a problem hiding this comment.
I trust the behavior of matchspec about as far as i can throw it, so keeping it explicit here
|
|
||
|
|
||
| def conda_spec_to_versioned_dep(spec: str, category: str) -> VersionedDependency: | ||
| from ..vendor.conda.models.match_spec import MatchSpec |
There was a problem hiding this comment.
could you add a docstring to this function?
| @@ -0,0 +1,7 @@ | |||
| channels: | |||
| - rapidsai | |||
| - nvidia | |||
There was a problem hiding this comment.
anything special about rapidsai and nvidia here? or could these be any channels. might be kind to future maintenance to leave a note about why you picked these two channels
This closes #188
This should allow us to be able to safely specify the channel as part of a lock spec.
Since this is a strict superset of the lockfile format we're choosing to not to increment the version number of a the lockfile spec here.